fix(browser): let the host own control request IDs - #413
Conversation
PR #413 delivery isolation — dedicated Astra reviewPASS — delivery isolation only. Audited clean head Scope and identity
Independent focused executionOn Node v22.23.2, with GNU sed selected for shell vocabulary mutations:
No full Rust/browser/package rebuild was needed for this content-identical delivery. The previously reviewed full wrapper, SDK/type/packed consumer, and actual-browser evidence remains applicable to unchanged files. This audit preserves closed #393 product PASS and independent #409 tooling PASS; it is not a fourth implementation attempt. Root owns review-ready marking, required remote qualification, and final GitHub synchronization. No repository edits, commits, pushes, merge, or publication were made by this reviewer. |
|
All required CI is green at reviewed head |
The browser host now allocates request IDs for all public control and observation calls. SDK console calls and direct host calls can interleave without maintaining competing counters, while typed acknowledgements retain the assigned ID and existing backpressure semantics.
This isolates the Astra-approved #393 capability and the separately Astra-approved #409 CI fixture correction. It excludes the unqualified PCM ownership move in #398. Rust, WASM, ABI identities and raw worklet messages are unchanged.
Validation: #393 dedicated review passed request/exhaustion mutations, packed type and runtime consumers, and Chromium/Firefox/Playwright WebKit qualification. #409 dedicated review passed the Node22.23.2 host suite, vocabulary mutations and deterministic zero/one-miss telemetry discriminators. The dedicated Astra isolated-branch audit passed at
1814bab9; all host/SDK/crate trees match the approved #393 checkpoint and the CI fixture matches approved #409. All required CI passed in run 33937802586 at the same head, including Chromium, Firefox and Playwright WebKit. No merge or package publication is claimed.Related completed issues: #393, #409.